Skip to content

Conversation

hajjimo
Copy link
Contributor

@hajjimo hajjimo commented Aug 25, 2025

Addresses #654

Required

  • Used LinkOut component on external links
  • Reviewed Vale errors and made changes where appropriate
  • Ran Prettier
  • Previewed updates in Netlify
  • Received SME and/or peer approval if updates are significant
  • Included a "fixes #" comment

Conditional

  • Ensured sequence diagrams follow our style guide
  • Included code samples where appropriate
  • Updated related READMEs

Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for openpayments-preview ready!

Name Link
🔨 Latest commit 176d8da
🔍 Latest deploy log https://app.netlify.com/projects/openpayments-preview/deploys/68d13de956134c00088a9c63
😎 Deploy Preview https://deploy-preview-675--openpayments-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hajjimo hajjimo marked this pull request as ready for review September 9, 2025 10:29
@hajjimo hajjimo requested a review from mkurapov September 9, 2025 10:29

This consistent structure enables multi-currency payments, precise calculations, and seamless integration between different <Tooltip content="Account servicing entity">ASEs</Tooltip>.

:::note[Wallet address asset constraint]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long-winded comment here. I know you added this note based on feedback from Max. What you've written is technically correct. But with what we have across all our other docs (basically, payments being currency-agnostic), I think this note could be misunderstood.

We need to decide who the audience is for this note. Is it the ASE? A developer? Both? Maybe this doesn't need to be a note, or have a heading, and be expanded a bit.

A wallet address supports only one specific asset, yes. But we don't want to lead people to believe that a wallet provider/ASE can only support one asset.

Amounts...will only be in the asset supported by the wallet..., true. But we don't want to lead people to believe that, for example, to send in USD, the recipient's wallet must be set up to accept USD.

I'm probably overthinking it. @mkurapov , what do you think?

- Add katex, rehype-katex, and remark-math to pnpm lock file
- Ensures CI/CD pipeline can install required dependencies
- Resolves build failure in GitHub Actions
Copy link
Contributor

@melissahenderson melissahenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content updates look good. I'd like for @JoblersTune to approve this if she's good with the LaTeX changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR

Copy link
Contributor

@JoblersTune JoblersTune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the package-lock.json has been removed it LGTM

@hajjimo hajjimo merged commit 440a5ba into main Sep 22, 2025
5 checks passed
@hajjimo hajjimo deleted the mi/654/amounts-assets branch September 22, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants