-
Notifications
You must be signed in to change notification settings - Fork 49
docs: mi/654/amounts-assets #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Draft of new amounts page.
✅ Deploy Preview for openpayments-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
||
This consistent structure enables multi-currency payments, precise calculations, and seamless integration between different <Tooltip content="Account servicing entity">ASEs</Tooltip>. | ||
|
||
:::note[Wallet address asset constraint] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long-winded comment here. I know you added this note based on feedback from Max. What you've written is technically correct. But with what we have across all our other docs (basically, payments being currency-agnostic), I think this note could be misunderstood.
We need to decide who the audience is for this note. Is it the ASE? A developer? Both? Maybe this doesn't need to be a note, or have a heading, and be expanded a bit.
A wallet address supports only one specific asset, yes. But we don't want to lead people to believe that a wallet provider/ASE can only support one asset.
Amounts...will only be in the asset supported by the wallet..., true. But we don't want to lead people to believe that, for example, to send in USD, the recipient's wallet must be set up to accept USD.
I'm probably overthinking it. @mkurapov , what do you think?
- Add katex, rehype-katex, and remark-math to pnpm lock file - Ensures CI/CD pipeline can install required dependencies - Resolves build failure in GitHub Actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content updates look good. I'd like for @JoblersTune to approve this if she's good with the LaTeX changes.
docs/package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file from the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the package-lock.json has been removed it LGTM
Addresses #654
Required
Conditional