Skip to content

Conversation

melissahenderson
Copy link
Contributor

@melissahenderson melissahenderson commented Sep 10, 2025

Description of changes

Required

  • Used LinkOut component on external links
  • Reviewed Vale errors and made changes where appropriate - NA
  • Ran Prettier
  • Previewed updates in Netlify
  • Received SME and/or peer approval if updates are significant
  • Included a "fixes #" comment

Conditional

  • Ensured sequence diagrams follow our style guide - NA
  • Included code samples where appropriate - NA
  • Updated related READMEs - NA

Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for openpayments-preview ready!

Name Link
🔨 Latest commit db01179
🔍 Latest deploy log https://app.netlify.com/projects/openpayments-preview/deploys/68d3ed5eaa02530008d73857
😎 Deploy Preview https://deploy-preview-684--openpayments-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@melissahenderson
Copy link
Contributor Author

melissahenderson commented Sep 10, 2025

@JoblersTune , @Anca2022 Help, please :)

Build errors re: invalid links.

Example:
es/concepts/auth/
/es/apis/auth-server/operations/post-continue - invalid link

Page's markdown:
...el cliente debe emitir una [solicitud de continuación de la concesión de autorización](/es/apis/auth-server/operations/post-continue), para...

This works locally.

I can play with the Markdown links to try to get them to work, but when these pages are re-translated in the future, they'll be translated based on the English versions, and any lang-specific changes I make to the content will be overwritten.

In the outgoing-grant-future-payments guide (for example), the links don't cause build errors when used with the linkout component:
<LinkOut href='/es/apis/wallet-address-server/operations/get-wallet-address/'>Cómo obtener una dirección de billetera</LinkOut>

But do with Markdown:
Llame a la [API Obtener dirección de billetera](/es/apis/wallet-address-server/operations/get-wallet-address) ...

@Anca2022
Copy link
Contributor

Anca2022 commented Sep 24, 2025

I think the build error you get has to do with the configuration of the starlightLinksValidator in astro.config.mjs.

You need to add an exception for the Spanish urls (the English API urls are already added to exceptions):

    starlightLinksValidator({
      errorOnLocalLinks: false,
      errorOnFallbackPages: false,
      exclude: [
        '/apis/{auth-server,resource-server,wallet-address-server}/**/*',
        '/es/apis/{auth-server,resource-server,wallet-address-server}/**/*'
      ]
    }),

@melissahenderson melissahenderson marked this pull request as ready for review September 24, 2025 13:13
@melissahenderson
Copy link
Contributor Author

Looks like Anca's suggestion worked.

@melissahenderson melissahenderson merged commit 664bac5 into main Sep 24, 2025
5 checks passed
@melissahenderson melissahenderson deleted the mh-es-api branch September 24, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants