Skip to content

fix(react): specify react peer dependency #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(react): specify react peer dependency #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
},
"peerDependencies": {
"@tanstack/react-query": "^5",
"firebase": "^11.3.0"
"firebase": "^11.3.0",
"react": "^18.0.0 || ^19.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

By adding react: '^18.0.0 || ^19.0.0' as a peer dependency, you are signaling that this package is compatible with React 18. However, the devDependencies only list React 19, which suggests testing might only be performed against React 19. To prevent potential runtime errors for users on React 18, it's recommended to also test the package against a React 18 environment to ensure full compatibility with the declared versions.

}
}