Fix issue where signal updates weren't getting picked up

[maneesht]

Fixed issue where if a user passes in a signal for an option, the signal change wouldn't get picked up.

[changeset-bot]

🦋 Changeset detected

Latest commit: 692ec8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@tanstack-query-firebase/angular	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[docs-page]

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~227

Documentation is deployed and generated using docs.page.

[gemini-code-assist]

Summary of Changes

Hello @maneesht, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue in the injectDataConnectQuery function where changes to Angular signals used within query options were not being detected, leading to stale data. The solution involves leveraging Angular's computed signals to establish reactivity, ensuring that queries automatically re-evaluate when their signal-driven inputs are updated. Additionally, several project dependencies have been upgraded to align with the latest Angular and Firebase versions.

Highlights

• Reactive Signal Handling: The injectDataConnectQuery function has been refactored to correctly react to changes in Angular signals passed as query options, particularly for query variables. This ensures that queries are re-executed when their signal-based inputs change.
• Dependency Updates: Key dependencies including @angular/core, @angular/fire, and the firebase peer dependency have been updated to support Angular v20 and Firebase v12, along with other related packages.
• Zoneless Change Detection API: The usage of provideExperimentalZonelessChangeDetection in test files has been updated to the stable provideZonelessChangeDetection API.
• New Test Coverage: A new test case has been added to injectDataConnectQuery.test.ts to specifically verify that signal updates are correctly processed, ensuring the fix works as intended.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where changes to signals used in query options were not being picked up. The core logic in injectDataConnectQuery is refactored to use computed signals correctly, ensuring reactivity. The changes also include updating dependencies to support Angular 20 and adding a new test case to verify the fix. My review includes a suggestion to further improve the efficiency and readability of the new signal-based logic by consolidating redundant computations.