Added log_traceback parameter to retry + improved logging by adding failed function reference #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailed function reference
Add on_exception handler called with captured exception by @warownia1
|
Seems to do the same thing as #44? |
the separate package is deprecated
this package is not actually used in the code of this project Closes #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a retry, the log message doesn't contain any information on what function performs retry, as well as only brief info about exception.
I've improved logging by adding in log the reference to the function being retried, as well as optional parameter
log_tracebackwhich when enabled will add to the log the traceback information about eception.