feat: handle deprecated #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0
added a commit
to goreleaser/goreleaser
that referenced
this pull request
Jun 14, 2023
pending invopop/jsonschema#79 the jsonschema should also have the correct deprecated markings Signed-off-by: Carlos Alexandro Becker <[email protected]>
Contributor
|
Thanks! Tests required. This probably wants to be supported in the array items also. |
Author
|
@samlown thanks, done! |
Author
|
@samlown merged, fixed conflicts |
Author
|
gently ping @samlown |
stefanhaller
reviewed
Jan 9, 2025
stefanhaller
left a comment
stefanhaller
left a comment
There was a problem hiding this comment.
Awesome feature, let me express my interest in having this.
Just one thought about the tag format below.
|
|
||
| // Tests for deprecated | ||
| DeprecatedField string `json:"deprecated_field" jsonschema:"deprecated=true"` | ||
| DeprecatedSlice []string `json:"deprecated_slice" jsonschema:"deprecated=true"` |
There was a problem hiding this comment.
I find it surprising that you have to add =true here. When would anybody ever set this to false? I would have expected that you just say jsonschema:"deprecated", like you do e.g. for json:"omitempty".
7 tasks
stefanhaller
added a commit
to jesseduffield/lazygit
that referenced
this pull request
Mar 23, 2025
) - **PR Description** This removes generated Config.md entries that are contain the word: `deprecated` (case insensitive) anywhere in their header comment. I think adding in deprecated configs into the reference config clutters it at best, and encourages users to use those configs at worst. They are still going to be validated by the schema, but this PR removes them from the generated config. I also added in the missing `deprecated` yaml tags in our user config in anticipation of invopop/jsonschema#79 getting merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows to set the
jsonschema:"deprecated=true"tag