Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@hmoog
Copy link
Contributor

@hmoog hmoog commented Jan 12, 2023

Description of change

Please write a summary of your changes and why you made them. Be sure to reference any related issues by adding fixes # (issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hmoog hmoog changed the title Feat: Started implementing cached map Feat: Started implementing cached ads map Jan 12, 2023
}

func (c *CachedMap[K, V, KPtr, VPtr]) writeLoop() {
for {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loop needs a way to be exited for cleanup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants