Skip to content

remove sha1 from list of hashes allowed in IPFS #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

remove sha1 from list of hashes allowed in IPFS #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb55ac8
remove sha1 from list of hashes allowed in IPFS
gammazero Aug 26, 2025
3017543
update changelog
gammazero Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ The following emojis are used to highlight certain changes:

### Removed

- remove sha1 from list of hashes allowed in IPFS [#1013](https://github.com/ipfs/boxo/pull/1013)

### Fixed

### Security
Expand Down
3 changes: 1 addition & 2 deletions verifcid/allowlist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,8 @@ func (defaultAllowlist) IsAllowed(code uint64) bool {
mh.IDENTITY,

mh.SHA3_224, mh.SHA3_256, mh.SHA3_384, mh.SHA3_512,
mh.KECCAK_224, mh.KECCAK_256, mh.KECCAK_384, mh.KECCAK_512,
mh.KECCAK_224, mh.KECCAK_256, mh.KECCAK_384, mh.KECCAK_512:

mh.SHA1: // not really secure but still useful for git
return true
default:
if code >= mh.BLAKE2B_MIN+19 && code <= mh.BLAKE2B_MAX {
Expand Down
2 changes: 1 addition & 1 deletion verifcid/allowlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func TestDefaultAllowList(t *testing.T) {
assertTrue(allowlist.IsAllowed(mh.DBL_SHA2_256))
assertTrue(allowlist.IsAllowed(mh.KECCAK_256))
assertTrue(allowlist.IsAllowed(mh.SHA3))
assertTrue(allowlist.IsAllowed(mh.SHA1))
assertFalse(allowlist.IsAllowed(mh.SHA1))
assertFalse(allowlist.IsAllowed(mh.BLAKE2B_MIN + 5))

cases := []struct {
Expand Down
Loading