generated from ipfs/ipfs-repository-template
    
        
        - 
                Notifications
    
You must be signed in to change notification settings  - Fork 138
 
Revert blockservice sessions context #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Jorropo
  wants to merge
  2
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
revert-bad-sessions-changes
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          
 This stack of pull requests is managed by Graphite. Learn more about stacking.  | 
    
d152c7c    to
    0912ba3      
    Compare
  
    
          Codecov Report✅ All modified and coverable lines are covered by tests. @@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   65.59%   65.56%   -0.04%     
==========================================
  Files         207      207              
  Lines       25612    25579      -33     
==========================================
- Hits        16801    16771      -30     
+ Misses       7338     7336       -2     
+ Partials     1473     1472       -1     
 ... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
  | 
    
  This was referenced Feb 14, 2024 
      
0912ba3    to
    e21efeb      
    Compare
  
    e21efeb    to
    d8d7675      
    Compare
  
    
    
  Jorropo 
      added a commit
        to ipfs/kubo
      that referenced
      this pull request
    
      Feb 16, 2024 
    
    
      
  
    
      
    
  
Keeps in sync with: - ipfs/boxo#578 - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
d8d7675    to
    66da324      
    Compare
  
    
              
                    hacdias
  
              
              approved these changes
              
                  
                    Feb 27, 2024 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.