fix: client bubbles up errors #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
added a commit
to ipfs/helia-verified-fetch
that referenced
this pull request
Apr 29, 2025
This was referenced Apr 29, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
## [@helia/delegated-routing-v1-http-api-client-v4.2.3](https://github.com/ipfs/helia-delegated-routing-v1-http-api/compare/@helia/delegated-routing-v1-http-api-client-4.2.2...@helia/delegated-routing-v1-http-api-client-4.2.3) (2025-04-29) ### Bug Fixes * client bubbles up errors ([#166](#166)) ([35308b4](35308b4))
|
🎉 This PR is included in version @helia/delegated-routing-v1-http-api-client-v4.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SgtPooki
added a commit
to ipfs/helia-verified-fetch
that referenced
this pull request
Apr 29, 2025
* fix: remove abortable-iterator depends on ipfs/helia-delegated-routing-v1-http-api#166 * chore: update delegated-routing-v1-http-api-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: client bubbles up errors
Description
Fixes an issue where an aborted verified-fetch call was not being respected by the libp2pRouting provided by @helia/routers, because delegated-routing-v1-http-api-client was swallowing the error.
Related ipfs/helia-verified-fetch#214
Related ipfs/service-worker-gateway#681
Related ipfs/helia#780
Related https://github.com/SgtPooki/repro-helia-libp2p-router-abort-handling
Related ipfs/service-worker-gateway#699
Notes & open questions
Change checklist