This repository was archived by the owner on Aug 21, 2024. It is now read-only.
studio: fix infinite scrolling #10951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achen5671
requested review from
CITIZENDOT,
SYBIOTE and
aditya-mitra
as code owners
DanielBelmes
suggested changes
Aug 13, 2024
dinomut1
suggested changes
Aug 13, 2024
HexaField
suggested changes
Aug 14, 2024
packages/ui/src/components/editor/panels/Assets/container/index.tsx
Outdated
Show resolved
Hide resolved
|
@dinomut1 @DanielBelmes hm weird, It seems to be working for me. I changed it to use abort controller as per @HexaField request and it's also seems to work. Can you guys rereview when you have a chance. ty! |
dinomut1
suggested changes
Aug 14, 2024
There was a problem hiding this comment.
Screencast from 08-14-2024 10:09:49 AM.webm
still seeing it. If you click on several categories one after the other it happens pretty consistently
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://tsu.atlassian.net/browse/IR-3743
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps