Implements User controller #368
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Nuckal777
reviewed
Sep 4, 2025
| return fmt.Errorf("failed to remove effective BMCSecret: %w", err) | ||
| } | ||
| // Update the BMC account with the new password | ||
| if err := bmcClient.CreateOrUpdateAccount(ctx, user.Spec.UserName, user.Spec.RoleID, password, r.Insecure); err != nil { |
There was a problem hiding this comment.
Don't we loose the reference to the password, if this call fails? I would propose to not remove the effective secret ref. Instead at the start of the reconciliation try to log in with the effective secret ref and if that fails try .spec.secretRef (if different). In case the second log in call succeeds, I would patch the effective secret ref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implement User controller which handles the creation of user accounts in a bmc