updated features @coderabbitai #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it expands to shell variables like "${prefix}"
/src/bin/d2/d2_process.cc
D2Process::runIO() - use new IOService::runOneFor()
/src/lib/asiolink/io_service.*
IOServcie::runOneFor() - new func
/src/lib/asiolink/io_service_mgr.*
IOServiceMgr::pollIOServices() - return count of
handlers executed
/src/lib/asiolink/tests/io_service_unittest.cc
TEST(IOService, runOneFor) - new test
modified: src/bin/d2/d2_process.cc modified: src/bin/d2/d2_process.h modified: src/lib/asiolink/tests/io_service_unittest.cc
new file: 4049-d2-hooks-may-not-have-their-ioservice-s-poll-method-called-frequently-enough
modified: d2_process.h
/src/bin/dhcp4/dhcp4_srv.*
Dhcpv4Srv::selectSubnet()
Dhcpv4Srv::selectSubnet4o6()
- remvoed sanity_only mode
Dhcpv4Srv::assignLease() - return without NAK on
non-matching rebind
Dhcpv4Srv::acceptDirectRequest() - remove call to selectSubnet()
/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
/src/bin/dhcp4/tests/direct_client_unittest.cc
/src/bin/dhcp4/tests/dora_unittest.cc
/src/bin/dhcp4/tests/shared_network_unittest.cc
Updated tests
added change log file
/src/bin/dhcp4/tests/classify_unittest.cc
TEST_F(ClassifyTest, earlySubnetNoFallback) - new test
The wiki page is obsolete and apparently not worth updating. No replacement is available. Just delete the entire sentence.
new file: changelog_unreleased/4086-password-leaked-to-logs
/src/lib/asiolink/process_spawn.*
ProcessSpawnImpl::getCommandLine() - modified to accept
ProcessSpawn::getCommandLine() - modified to accept
a list of arguments whose values should be redacted
/src/lib/asiolink/tests/process_spawn_unittest.cc
TEST_F(ProcessSpawnTest, getCommandLineRedacted) - new test
/src/lib/mysql/mysql_connection.cc
MySqlConnection::initializeSchema() - add list of args to redact to
getCommandLine() call
/src/lib/pgsql/pgsql_connection.cc
PgSqlConnection::initializeSchema() - add list of args to redact to
getCommandLine() call
modified: changelog_unreleased/4086-password-leaked-to-logs modified: src/lib/asiolink/process_spawn.cc modified: src/lib/asiolink/tests/process_spawn_unittest.cc modified: src/lib/mysql/mysql_connection.cc modified: src/lib/pgsql/pgsql_connection.cc
src/lib/asiolink/process_spawn.cc
User count() instead of contains()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.