-
Couldn't load subscription status.
- Fork 35
fix: add missing integer type mappings to dtype from_str #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There's no reason why `i16` should be missing, especially since `i8`, `i32`, `i64` exist. Also added `u16`, `u32`, `u64` for similar reasons; there's already `u8`, `uint8`, `uint16`, `uint32`, `uint64`.
Summary of ChangesHello @JaryJay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR addresses a missing feature by extending the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the missing integer type string representations. I've added one comment regarding the maintainability of the from_str method, which could be improved in a follow-up to prevent similar issues in the future.
Replaced the from_str method's dictionary with a lookup map for better maintainability
Added
b,i16,u16,u32,u64mappings tofrom_strindtype.py.Did this by implementing Gemini Code Assist's suggestion, which was to create a map at runtime with all the mappings from each dtype's name and short name.
This change allows
b,i16,u16,u32, andu64to be passed in as arguments when running model_gen with themgen.dtype_choicesoption, e.g.:nnsmith.model_gen ... mgen.dtype_choices="[b, i16, u16, u32, u64]"