-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ES] Issue #16684: pendings translations to Spanish (Split PR 3) #16742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…87-108) Signed-off-by: Francisco Herrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments.
Also, it was expected to have all the platform setup translated? I've seen just some of them (Maybe they are in another split PR): https://deploy-preview-16742--preliminary-istio.netlify.app/latest/es/docs/setup/platform-setup/
Signed-off-by: Francisco Herrera <[email protected]>
Changes from review done |
Signed-off-by: Francisco Herrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, I've just added a couple of comments (And I realized there is just one change in the files but they are not fully translated, so it is Ok to merge as it is if the translation for these files was not planed here)
Co-authored-by: Josune Cordoba <[email protected]>
Yes, there is still some parts of the setup not translated. We have two more PR's with pending translations. Once this is done I'll do a resume about which are still the pendings to prioritize this |
Yeah, this was becuase I added the definition translation and if I do not do the change in all the files the lint will fail |
Description
I split the original PR: #16691 into multiple PR to make it easy to review
Reviewers