Skip to content

[ES] Issue #16684: pendings translations to Spanish (Split PR 3) #16742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fjglira
Copy link
Contributor

@fjglira fjglira commented Aug 1, 2025

Description

I split the original PR: #16691 into multiple PR to make it easy to review

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@fjglira fjglira requested a review from a team as a code owner August 1, 2025 15:50
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2025
Copy link
Contributor

@josunect josunect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments.
Also, it was expected to have all the platform setup translated? I've seen just some of them (Maybe they are in another split PR): https://deploy-preview-16742--preliminary-istio.netlify.app/latest/es/docs/setup/platform-setup/

Signed-off-by: Francisco Herrera <[email protected]>
@fjglira fjglira requested a review from josunect August 11, 2025 07:53
@fjglira
Copy link
Contributor Author

fjglira commented Aug 11, 2025

Changes from review done

Copy link
Contributor

@josunect josunect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, I've just added a couple of comments (And I realized there is just one change in the files but they are not fully translated, so it is Ok to merge as it is if the translation for these files was not planed here)

@fjglira
Copy link
Contributor Author

fjglira commented Aug 14, 2025

I've added some comments. Also, it was expected to have all the platform setup translated? I've seen just some of them (Maybe they are in another split PR): https://deploy-preview-16742--preliminary-istio.netlify.app/latest/es/docs/setup/platform-setup/

Yes, there is still some parts of the setup not translated. We have two more PR's with pending translations. Once this is done I'll do a resume about which are still the pendings to prioritize this

@fjglira
Copy link
Contributor Author

fjglira commented Aug 14, 2025

LG, I've just added a couple of comments (And I realized there is just one change in the files but they are not fully translated, so it is Ok to merge as it is if the translation for these files was not planed here)

Yeah, this was becuase I added the definition translation and if I do not do the change in all the files the lint will fail

@fjglira fjglira requested a review from josunect August 14, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants