Skip to content

Fix sanity check when null Field got no parent #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix sanity check when null Field got no parent #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions itext/itext.forms/itext/forms/PdfAcroForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,9 @@ private IDictionary<String, PdfFormField> IterateFields(PdfArray array, IDiction
String name;
if (fieldName == null) {
PdfFormField parentField = PdfFormField.MakeFormField(formField.GetParent(), document);
if (parentField == null){
continue;
}
while (fieldName == null) {
fieldName = parentField.GetFieldName();
if (fieldName == null) {
Expand Down
2 changes: 1 addition & 1 deletion itext/itext.forms/itext/forms/fields/PdfFormField.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1646,7 +1646,7 @@ public static PdfChoiceFormField CreateList(PdfDocument doc, Rectangle rect, Str
/// <c>pdfObject</c> does not contain a <c>FT</c> entry
/// </returns>
public static iText.Forms.Fields.PdfFormField MakeFormField(PdfObject pdfObject, PdfDocument document) {
if (pdfObject.IsDictionary()) {
if (pdfObject != null && pdfObject.IsDictionary()) {
iText.Forms.Fields.PdfFormField field;
PdfDictionary dictionary = (PdfDictionary)pdfObject;
PdfName formType = dictionary.GetAsName(PdfName.FT);
Expand Down