🎉1️⃣1️⃣ payment_wechat #1270
Merged
🎉1️⃣1️⃣ payment_wechat #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trojikman
commented
Jun 17, 2020
em230418
suggested changes
Jun 18, 2020
There was a problem hiding this comment.
Мимо проходил. В запросы на внешние сервера надо timeout выставить.
https://requests.readthedocs.io/en/master/user/quickstart/#timeouts
Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely
trojikman
commented
Jun 18, 2020
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo> | |||
There was a problem hiding this comment.
@yelizariev нужна эта вьюшка? она в манифесте не подключена
There was a problem hiding this comment.
Хотя я думал что Динар будет ругаться, не ругается оказывается
There was a problem hiding this comment.
Да, нужна скорее всего. Не знаю почему не подключена
|
Модуль пока неустанавливаемый так как не закончен, вливаю так |
|
I approve to merge it now |
|
Approved by @trojikman
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #1181