clarify use of VOTable for numbers and boolean, issue #41 #51
Conversation
There was a problem hiding this comment.
The changes look ok, although given the repeated text about arraysize in string-valued fields and perhaps also the stereotypical "FIELD and/or PARAM" would suggest to me that an introductory section with some definitions would make the thing more readable. It could say
- In the following, if we say string-valued, this is VOTable datatype char or unicodeChar with arraysize either * or fixed or fixed with limit, but 1D only
- In the following if we say "VOTable value metadata element", we mean either a VOTable FIELD or VOTable PARAM element.
In particular the unicodeChar clarification is, I think, something we'll be grateful for one day, but either way, having these things in one place will help DRY, which is mostly a good thing.
Also, as long as we do PRs, I think it would be cool if there'd be at least a few words on the motivation of non-trivial PRs in their descriptions, and this one feels almost non-trivial...
general explantion of that arraysize * usage generalise concept of VOTable type metadata reformat xtype usage using verbatim rather than inline reorg a few xtype sections to follow consistent structure
There was a problem hiding this comment.
Apart from comments above, this looks fine to me.
I would probably have avoided repeated text by putting at the top something like
- floating point means datatype=float or double
- integer means datatype=short, int or long
- numeric means floating point or integer
- string means datatype=char or unicodeChar and arraysize=* or N or N*
and then used those terms rather than providing explicit datatypes in the individual items. But if you prefer it like this it's OK.
No description provided.