Fix infinity scrolling #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storyboard support would be amazing! thanks |
|
+1 more on the Storyboard support please! :) Thanks |
|
Please add a storyboard support. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently started to use JMStatefulTableViewController 0.1.1 with SVPullToRefresh 0.4.1.
It seemed to me that issue #1 is still there. By digging code I realized that issue happens because after our callback in
statefulTableViewControllerWillBeginLoadingNextPage:SVInfiniteScrollingView still has SVInfiniteScrollingStateLoading state and can't fire the handler. As mentioned in SVPullToRefresh docs you should manually call[tableView.infiniteScrollingView stopAnimating]inside infinity scrolling handler when you've done. It switches state to SVInfiniteScrollingStateStopped. I've added needed calls to_loadNextPageand it seems like everything works fine.I've also added
initWithCoder:for correct initialization of my controllers which instantiated from storyboards.Sorry if I'm wrong with something. Thanks.