replace embassy_usb_driver import with re-export from embassy_usb #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most embassy users use the git version by pathing crates-io. Its easy to forget to patch both embassy-usb and embassy-usb-driver. By relying on embassy-usb-driver as re-exported by embassy-usb that can no longer happen.
|
I'm not certain I want to merge this. I think the intent of relying on e-u-driver is to have fewer breaking changes as that crate changes less often than e-u does. That being said, I wasn't able to make that work for the 0.2 to 0.3 transition, so maybe there isn't much value to that. |
|
I am fine with leaving this open for a while (be that months or years) or closing it. Its a small change it does not matter to me who makes it if its made at all 👍. Do whatever is most convenient for you, and thanks for making postcard & postcard-rpc. They are both very nice (love the inclusion of the CobsAccumulator btw that saved me quite some time). |
jamesmunns
added
the
Q2 '25 Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most embassy users use the git version by pathing crates-io. Its easy to forget to patch both embassy-usb and embassy-usb-driver. By relying on embassy-usb-driver as re-exported by embassy-usb that can no longer happen.