Skip to content

Conversation

shun2wang
Copy link
Contributor

@shun2wang shun2wang commented Aug 17, 2025

Fix: jasp-stats/jasp-issues#3008
Fix: https://github.com/jasp-stats/INTERNAL-jasp/issues/2794
Fix: jasp-stats/jasp-issues#3620

replace: #5793

This PR may cause the old comparison table unit test to fail. In this case, you may need to refresh the old JASP files.

@shun2wang shun2wang changed the title Fix table cell vertical-align table export styles bugfix: fix table cell vertical-align table export styles Aug 17, 2025
@shun2wang shun2wang marked this pull request as draft August 18, 2025 02:31
add qmlls configguration file to .gitignore
@shun2wang shun2wang marked this pull request as ready for review August 22, 2025 15:48
@shun2wang shun2wang requested a review from boutinb August 28, 2025 14:59
@shun2wang
Copy link
Contributor Author

@boutinb Could you have a look?

Copy link
Contributor

@boutinb boutinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I still see an issue in this case:
Screenshot 2025-10-02 at 17 33 50

But this is already must better than before!

@shun2wang
Copy link
Contributor Author

Great! I still see an issue in this case:
Screenshot 2025-10-02 at 17 33 50

But this is already must better than before!

Good find, I will have a look. did you tried vertical alignment of exponential numbers?

@boutinb
Copy link
Contributor

boutinb commented Oct 2, 2025

Good find, I will have a look. did you tried vertical alignment of exponential numbers?

As far as I can see, alignment works well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Remove bold for lower line in descriptive tables [Bug]: Output/columns don't copy neatly
2 participants