[pallas:sc] Avoid putting tracers into params of dma_* primitives #32506
+89
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
Note that `jax_enable_checks` didn't catch this, because the tracers are hidden inside a non-pytree `NDIndexer` object. PiperOrigin-RevId: 817555725
copybara-service
bot
force-pushed
the
test_817555725
branch
from
bf967a3 to
22e7c7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pallas:sc] Avoid putting tracers into params of dma_* primitives
Note that
jax_enable_checksdidn't catch this, because the tracers are hidden inside a non-pytreeNDIndexerobject.