-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Migrate tests to JUnit5 #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Migrate tests to JUnit5 #1734
Conversation
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
7472190
to
fb945f1
Compare
For some reason
I also see this test failing locally when running the class. Running the test alone however works fine. Adding |
* ReaperListenerWatchEvent converted to record * CapturingReaperListener#CAPTURED_EVENTS not static anymore. Removed Junit extension as it was not actually needed. * Use await() instead of relying on java monitor and synchronized.
Addressed |
# Conflicts: # src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesPipelineTest.java
ConfigMapVolume configMapVolume = new ConfigMapVolume("oneMountPath", "Myvolume", false); | ||
configMapVolume.setSubPath("miSubpath"); | ||
assertEquals(configMapVolume.getSubPath(), "miSubpath"); | ||
assertEquals("miSubpath", configMapVolume.getSubPath()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR aims to migrate all tests to JUnit5. Changes include:
I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.
Submitter checklist