fix(ci): make unique and improve Github workflow job ids to make it easier to reference them from Github settings #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asier to reference them from Github settings Refs: a4da94f
behnazh
requested changes
Jun 14, 2025
.github/workflows/pr-change-set.yaml
Outdated
|
|
||
| jobs: | ||
| build: | ||
| build-package: |
There was a problem hiding this comment.
Suggested change
| build-package: | |
| check-and-build-package: |
There was a problem hiding this comment.
Commit 2adc4d5.
Also, should we then rename _build.yaml to _check_and_build.yaml? The only job in this reusable workflow is also named check-and-build-package so maybe renaming the workflow file would improve consistency between file name and executed jobs? 🤔
There was a problem hiding this comment.
I think the current file name is intuitive, and build should only pass when checks pass anyway.
.github/workflows/release.yaml
Outdated
|
|
||
| jobs: | ||
| check: | ||
| check-package-for-release: |
There was a problem hiding this comment.
We also trigger this job on push to the main branch.
Suggested change
| check-package-for-release: | |
| check-and-build-package: |
.github/workflows/release.yaml
Outdated
| bump: | ||
| needs: check | ||
| bump-package-version: | ||
| needs: [check-package-for-release] |
There was a problem hiding this comment.
Suggested change
| needs: [check-package-for-release] | |
| needs: [check-and-build-package] |
behnazh
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: a4da94f