Some mu4e fixes (#200, draft not removed, draft editing issues (tested in v1.12.8) #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes jeremy-compostella#200 remove undo from message-sent-hook as it was causing an error and for html drafts to be sent after successful message sending (unintended behavior). Also discussed in jeremy-compostella#182 where the hook was suspected to be causing problems jeremy-compostella#182 Note, in jeremy-compostella#182 multiple users report no issues after removing hook. As requested, only turn remove hook from mu4e
This matches the behavior of message-mode
org-msg.el
Outdated
| (insert-file-contents-literally | ||
| (mu4e-message-readable-path msg) nil nil nil t) | ||
| (org-msg-article-htmlp)))) | ||
| (when msg |
There was a problem hiding this comment.
What do you think of using the when-let macro instead? ?
There was a problem hiding this comment.
I replaced this by when-let* as according to [1], when-let is marked as obsolete for emacs 31.1
[1] https://lists.gnu.org/archive/html/emacs-diffs/2024-10/msg00346.html
org-msg.el
Outdated
| (setq-local message-sent-message-via nil) | ||
| (add-hook 'message-send-hook 'org-msg-prepare-to-send nil t) | ||
| (add-hook 'message-sent-hook 'undo t t) | ||
| (if (not (equal mail-user-agent #'mu4e-user-agent)) |
There was a problem hiding this comment.
oups, sorry for this 🤦, this is now fixed
When editing a mu4e draft, the message doesn't have parent. This leads to a "mu4e-warn: [mu4e] No message at point" This commit aims to fix this
seblemaguer
force-pushed
the
some_fixes
branch
from
e7b5447 to
ed35b0f
Compare
This was referenced Oct 29, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #204 and #201 to fix several issues:
mu4e-warn: [mu4e] No message at point. This PR (especially the commit e7b5447) fixes this as wellI did my best to test the different commits, but I didn't systematize it.