Python3 fixes #137
Open
Python3 fixes #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtbarnes
reviewed
Aug 11, 2018
| self.type = Type(cursor.type, cursor=cursor) | ||
|
|
||
| def compare_same(self, other): | ||
| def cmp(a, b): |
There was a problem hiding this comment.
I was going to submit a PR to do exactly this. Just wanted to note that the author has actually already defined this new cmp function. So instead of defining it here, just add an import at the top of the file,
from ..cmp import cmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running cldoc with current Python 3.6.5 required two patches:
cmp(), re-defining manually