Issue #13509 - Fix multipart usage with Servlet dispatch. #13518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
changed the title
gregw
requested changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13509
Fix for multipart when used through a forward or include dispatch.
Currently
ServletApiRequestdoes a call toServletMultiPartFormData.getParts(this)in itsgetParts()implementation, and this bypasses theMULTIPART_CONFIG_ELEMENTattribute set available on theForwardRequest/IncludeRequestwrappers.So this PR sets the wrapped request into this request attribute
WRAPPED_REQUEST_ATTRIBUTE, and then looks for this in theServletApiRequest.getPartsimplementation.I don't love this solution, so feel free to suggest a better one if you can think of one.