Ensure buffer is always released from HTTP/3 HeadersGenerator in case of failure. #13549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of failure. Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a failed test from
org.eclipse.jetty.test.client.transport.HttpClientTest#testInvalidFieldValuesabout a buffer being acquired but never released.This was because there was an error when encoding the headers, and in
HeadersGeneratorthe buffer was being allocated but not being added to theaccumulatorand only buffers in theaccumulatorwere being released on failure.This change fixes the test failure (not sure why the failure is not showing up in CI).