Make BufferUtil.toMappedBuffer(Path) catch UnsupportedOperationException
#13565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionException and add related tests Signed-off-by: Ludovic Orban <[email protected]>
gregw
previously approved these changes
Sep 8, 2025
There was a problem hiding this comment.
This is a good fix.
However, I'm also wondering if we should maintain a set of FileSystems from the passed in Path filePath that throw UOE and if a path is from such a file system, we just return null without the expense of creating an exception on every lookup.
For the most common case, the cost of looking at an empty set should be trivial.
On the other hand, perhaps the content cache makes this unnecessary?
Either way, if you think we should consider this, then merge this PR and open an enhancement issue for later consideration.
Signed-off-by: Ludovic Orban <[email protected]>
|
I'm of the opinion that the content cache makes any form of |
gregw
approved these changes
Sep 9, 2025
joakime
approved these changes
Sep 9, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Jetty 12.1.2 - FROZEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferUtil.toMappedBuffer(Path)was meant to catchUnsupportedOperationExceptionbut it mistakenly was coded to catchUnsupportedEncodingExceptioninstead.Fix the typo and add related tests.
Fixes #13563