Skip to content

support for direct-download cmd #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 6, 2025
Merged

support for direct-download cmd #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dfbf1f6
add direct cmd support
reshmifrog Sep 17, 2025
f384ccf
refactored direct download logic
reshmifrog Sep 22, 2025
6d92673
fix linters:
reshmifrog Sep 22, 2025
12d96a2
resolved gostatic lint
reshmifrog Sep 22, 2025
f0cefc4
added comments , renamed the direct download api
reshmifrog Sep 25, 2025
4f99b3a
refactor ddl command logic
reshmifrog Oct 8, 2025
39ec219
merge upstream/master
reshmifrog Oct 22, 2025
2fc925f
refactor logic
reshmifrog Oct 27, 2025
d0c7a22
fix security vulnerability, updated dependency
reshmifrog Oct 28, 2025
00fe9c9
removed unnecessary logs,remove lints:
reshmifrog Oct 28, 2025
10a13bc
fix lint
reshmifrog Oct 28, 2025
27ae405
fixed linter
reshmifrog Oct 28, 2025
499e4a1
upstream
reshmifrog Nov 5, 2025
32ebbc8
fixed windows path issue:
reshmifrog Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions artifactory/emptymanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ type ArtifactoryServicesManager interface {
ReadRemoteFile(readPath string) (io.ReadCloser, error)
DownloadFiles(params ...services.DownloadParams) (totalDownloaded, totalFailed int, err error)
DownloadFilesWithSummary(params ...services.DownloadParams) (operationSummary *utils.OperationSummary, err error)
DirectDownloadFiles(params ...services.DirectDownloadParams) (totalDownloaded, totalFailed int, err error)
DirectDownloadFilesWithSummary(params ...services.DirectDownloadParams) (operationSummary *utils.OperationSummary, err error)
GetUnreferencedGitLfsFiles(params services.GitLfsCleanParams) (*content.ContentReader, error)
SearchFiles(params services.SearchParams) (*content.ContentReader, error)
Aql(aql string) (io.ReadCloser, error)
Expand Down Expand Up @@ -252,6 +254,14 @@ func (esm *EmptyArtifactoryServicesManager) DownloadFilesWithSummary(...services
panic("Failed: Method is not implemented")
}

func (esm *EmptyArtifactoryServicesManager) DirectDownloadFiles(...services.DirectDownloadParams) (int, int, error) {
panic("Failed: Method is not implemented")
}

func (esm *EmptyArtifactoryServicesManager) DirectDownloadFilesWithSummary(...services.DirectDownloadParams) (*utils.OperationSummary, error) {
panic("Failed: Method is not implemented")
}

func (esm *EmptyArtifactoryServicesManager) GetUnreferencedGitLfsFiles(services.GitLfsCleanParams) (*content.ContentReader, error) {
panic("Failed: Method is not implemented")
}
Expand Down
19 changes: 19 additions & 0 deletions artifactory/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,14 @@ func (sm *ArtifactoryServicesManagerImp) initDownloadService() *services.Downloa
return downloadService
}

func (sm *ArtifactoryServicesManagerImp) initDirectDownloadService() *services.DirectDownloadService {
directDownloadService := services.NewDirectDownloadService(sm.config.GetServiceDetails(), sm.client)
directDownloadService.DryRun = sm.config.IsDryRun()
directDownloadService.Threads = sm.config.GetThreads()
directDownloadService.Progress = sm.progress
return directDownloadService
}

func (sm *ArtifactoryServicesManagerImp) DownloadFiles(params ...services.DownloadParams) (totalDownloaded, totalFailed int, err error) {
downloadService := sm.initDownloadService()
summary, e := downloadService.DownloadFiles(params...)
Expand All @@ -296,6 +304,17 @@ func (sm *ArtifactoryServicesManagerImp) DownloadFilesWithSummary(params ...serv
return downloadService.DownloadFiles(params...)
}

func (sm *ArtifactoryServicesManagerImp) DirectDownloadFiles(params ...services.DirectDownloadParams) (totalDownloaded, totalFailed int, err error) {
directDownloadService := sm.initDirectDownloadService()
return directDownloadService.DirectDownloadFiles(params...)
}

func (sm *ArtifactoryServicesManagerImp) DirectDownloadFilesWithSummary(params ...services.DirectDownloadParams) (operationSummary *utils.OperationSummary, err error) {
directDownloadService := sm.initDirectDownloadService()
directDownloadService.SetSaveSummary(true)
return directDownloadService.DirectDownloadFilesWithSummary(params...)
}

func (sm *ArtifactoryServicesManagerImp) GetUnreferencedGitLfsFiles(params services.GitLfsCleanParams) (*content.ContentReader, error) {
gitLfsCleanService := services.NewGitLfsCleanService(sm.config.GetServiceDetails(), sm.client)
gitLfsCleanService.DryRun = sm.config.IsDryRun()
Expand Down
Loading
Loading