Skip to content

paginate_by ListView confliction fix #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

paginate_by ListView confliction fix #960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1c0098
implemented new paginate_table_by namespace that allows per_page to b…
JordanHyatt Sep 18, 2024
bc33faa
modified doc string
JordanHyatt Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion django_tables2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def get_table_pagination(self, table):
paginate = {}

# Obtains and set page size from get_paginate_by
paginate_by = self.get_paginate_by(table.data)
paginate_by = self.get_paginate_by(table.data) or self.get_paginate_table_by(table.data)
if paginate_by is not None:
paginate["per_page"] = paginate_by

Expand Down Expand Up @@ -73,6 +73,18 @@ def get_paginate_by(self, table_data) -> Optional[int]:
"""
return getattr(self, "paginate_by", None)

def get_paginate_table_by(self, table_data) -> Optional[int]:
"""
Alternate method for setting paginate_by that does not conflict with ListView

Args:
table_data: The table's data.

Returns:
Optional[int]: Items per page or ``None`` for no pagination.
"""
return getattr(self, "paginate_table_by", None)


class SingleTableMixin(TableMixinBase):
"""
Expand Down