Move authentication test files generation to test_unit
specific generator
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the authentication generator is currently creating
minitest
specific files regardless of the testing framework used by the user's application.This can be replicated by:
rspec-rails
to the app.rails g authentication
This will create
test/mailers/previews/passwords_mailer_preview.rb
andtest/test_helpers/session_test_helper.rb
(this last one only if usingrails
frommain
), regardless of the test framework beingrspec
.Detail
This Pull Request changes the authentication generator, moving the steps that involve creating test related files to the
test_unit
specific generator.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]