Skip to content

Add support for 'is.firefox' #32 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for 'is.firefox' #32 #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/is/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ export function isWindowObject(value) {
return value != null && typeof value === 'object' && 'setInterval' in value;
}

/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be done here, but rather environment.js as mentioned in the issue.

* Returns whether the current browser is Firefox
*/
export function isFirefox() {
return typeof InstallTrigger !== 'undefined';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use isUndefined from types.js

}

export default {
object: isObject,
array: isArray,
Expand All @@ -142,4 +149,5 @@ export default {
regexp: isRegexp,
undefined: isUndefined,
windowObject: isWindowObject,
firefox: isFirefox,
};