Removed explicit $VERSION from lib/Log/Any.pm #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dist::Zilla won't write a $VERSION if you've manually set it. [PkgVersion] skipping lib/Log/Any.pm: assigns to $VERSION Assuming the manual $VERSION is an oversight rather than intentional.
|
Definitely an oversight - fixed in 0.14. Thanks! Jon On Aug 30, 2011, at 5:46 PM, sdt wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jonathan,
I noticed that in the Log-Any-0.13 release, $Log::Any::VERSION is still 0.12.
I also noticed you were using Dist::Zilla::Plugin::PkgVersion, and the other modules had the right version number.
Then it dawned on me that you were manually setting the $VERSION in Any.pm, which means dzil won't overwrite it.
I'm assuming the manual $VERSION is an oversight rather than intentional.
Steve