Fix initial height check #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial height check truncated text if the original height was greater than or equal to the max allowable height, where it should only truncate if the original height is strictly greater than the max allowable height. This change makes the initial check consistent with the exit condition check, which checks if the current height is less than or equal to the max allowable height.
aamir1995
added a commit
to aamir1995/clamp.ts
that referenced
this pull request
Jan 31, 2022
copied from: josephschmitt/Clamp.js#44
aamir1995
added a commit
to aamir1995/clamp.ts
that referenced
this pull request
Jan 31, 2022
…#3) * fix": rename interface. * fix: https://github.com/josephschmitt/Clamp.js/pull/18/files * fix: don't append 'px' to opt.clamp. it already has it. copied from josephschmitt/Clamp.js#20 * fix initial height check. copied from: josephschmitt/Clamp.js#44 * fix: minor type * fix: return if `target` is not defined in `truncate` * fix: pass jshint copied from: josephschmitt/Clamp.js#54 * fix: problem with non-integer line height. partially copied from: josephschmitt/Clamp.js#66 * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial height check truncated text if the original
height was greater than or equal to the max allowable height,
where it should only truncate if the original height is
strictly greater than the max allowable height.
This change makes the initial check consistent with the
exit condition check, which checks if the current height
is less than or equal to the max allowable height.