Skip to content

Conversation

zosnap
Copy link

@zosnap zosnap commented Dec 11, 2015

The initial height check truncated text if the original
height was greater than or equal to the max allowable height,
where it should only truncate if the original height is
strictly greater than the max allowable height.

This change makes the initial check consistent with the
exit condition check, which checks if the current height
is less than or equal to the max allowable height.

The initial height check truncated text if the original
height was greater than or equal to the max allowable height,
where it should only truncate if the original height is
strictly greater than the max allowable height.

This change makes the initial check consistent with the
exit condition check, which checks if the current height
is less than or equal to the max allowable height.
aamir1995 added a commit to aamir1995/clamp.ts that referenced this pull request Jan 31, 2022
aamir1995 added a commit to aamir1995/clamp.ts that referenced this pull request Jan 31, 2022
…#3)

* fix": rename interface.

* fix: https://github.com/josephschmitt/Clamp.js/pull/18/files

* fix: don't append 'px' to opt.clamp. it already has it.

copied from josephschmitt/Clamp.js#20

* fix initial height check.

copied from: josephschmitt/Clamp.js#44

* fix: minor type

* fix: return if `target` is not defined in `truncate`

* fix: pass jshint

copied from: josephschmitt/Clamp.js#54

* fix: problem with non-integer line height.

partially copied from: josephschmitt/Clamp.js#66

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant