-
Notifications
You must be signed in to change notification settings - Fork 11
solution to the Dominator exercise #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fogha
wants to merge
11
commits into
jsacademyio:master
Choose a base branch
from
fogha:dominator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d071339
Armand's assignment
fogha 94c88e1
fix
fogha f2b50ce
Solution to anagram exercise
fogha b95437b
anagram solution
fogha 2cb7706
initial
fogha b5a710f
anagrma solution
fogha c18b249
staircase exercise
fogha e14d484
staircase
fogha f5ef654
dominator
fogha 7d1ab86
dominator
fogha e37bffc
fixed function return
fogha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
|
||
|
||
const dominator = (arr) => { | ||
let values = {}; | ||
let maxValue = arr.length/2 | ||
let dominator; | ||
|
||
for(let val of arr) { | ||
if(values[val] == null) { | ||
values[val] = 1; | ||
} else { | ||
values[val]++; | ||
} | ||
} | ||
|
||
for(let count of arr) { | ||
if(values[count] > maxValue) { | ||
dominator = count; | ||
} | ||
} | ||
|
||
if(dominator) { | ||
return arr.indexOf(dominator); | ||
} | ||
return -1 | ||
} | ||
|
||
console.log(dominator([3, 4, 2, 3, 3, 2, -1, 3, 3])); | ||
console.log(dominator([3, 4, 2, 3, 2, 2, -1, 3, 3])); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fogha your function doesn't return the required values.
The question clearly states:
returns the index of any element of array A in which the dominator of A occurs. The function should return −1 if array A does not have a dominator.