First PR #27
Open
First PR #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCarl857
requested changes
May 22, 2020
|
Alright thanks
…On Fri, May 22, 2020 at 9:13 AM Daniel Carlson ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In Week1/assignments/Bright/Exercise#12.js
<#27 (comment)>
:
> + for ( var i = 0; i < mid; i++ ) {
+ if (str[i] !== str[lent - 1 - i]) {
+ return false;
+ }
+ }
+
+ return true;
+}
+// test case
+console.log(palindrome("mom"));
+
+
+
+
+
+/* function reverseString(str) {
Try to not submit code with dead code included. Please take this out.
Good attempt though :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIK3MHLHWX2HLMYOLSWXQK3RSYX2RANCNFSM4NHPAWNQ>
.
|
DanCarl857
requested changes
May 22, 2020
| return true; | ||
| } | ||
| // test case | ||
| console.log(palindrome("mom")); |
There was a problem hiding this comment.
Your algorithm will fail for a case such as Racecar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.