-
Notifications
You must be signed in to change notification settings - Fork 39
open source -> open-source #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@akirataguchi115 is attempting to deploy a commit to the JSON Resume Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request updates text descriptions across several files to ensure consistent hyphenation. The phrase "open source" is changed to "open‑source" in the JSON Resume initiative descriptions found in documentation and code pages, as well as in a sample resume object's summary field. No functional, logical, or control flow changes were made. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it’s a critical failure. 🔧 ESLint
apps/homepage2/app/page.jsOops! Something went wrong! :( ESLint: 8.57.1 Error: ESLint configuration in apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo is invalid:
Referenced from: /packages/eslint-config-custom/index.js apps/homepage2/app/schema/page.jsOops! Something went wrong! :( ESLint: 8.57.1 Error: ESLint configuration in apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo is invalid:
Referenced from: /packages/eslint-config-custom/index.js apps/registry/app/page.jsOops! Something went wrong! :( ESLint: 8.57.1 Error: ESLint configuration in apps/registry/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo is invalid:
Referenced from: /packages/eslint-config-custom/index.js
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/registry/pages/api/samples/resume.js (1)
186-188
: Consistent Terminology Suggestion.
The summary correctly updates the phrase to "open‑source initiative" at the start. However, later in the sentence the text still reads "open source tools." For complete consistency, consider updating that occurrence to "open‑source tools."Suggested diff:
- ...with an ecosystem of open source tools", + ...with an ecosystem of open‑source tools",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
README.md
(1 hunks)apps/homepage2/app/page.js
(1 hunks)apps/homepage2/app/schema/page.js
(1 hunks)apps/registry/app/page.js
(1 hunks)apps/registry/pages/api/samples/resume.js
(1 hunks)
🔇 Additional comments (4)
apps/homepage2/app/page.js (1)
12-12
: Hyphenation Update Confirmed.
The text now correctly uses "open‑source" as a compound modifier to describe the initiative, which improves clarity and consistency.apps/homepage2/app/schema/page.js (1)
31-31
: Correct Hyphenation in Description.
Changing "open source" to "open‑source" in the paragraph enhances grammatical accuracy without affecting functionality.README.md (1)
8-8
: Documentation Terminology Updated.
The phrase now reads “A community-driven open‑source initiative…” which aligns with the intended use as a compound modifier and maintains consistency across the project.apps/registry/app/page.js (1)
227-229
: Footer Text Consistency.
The footer text now properly reflects the corrected terminology by using "open‑source" instead of "open source," ensuring uniformity with other parts of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeahhhhhhh
"open source" is a lexicalized compound noun. "open-source" is a compound modifier which is what was probably meant here.
https://opensource.org/blog/is-open-source-ever-hyphenated
Summary by CodeRabbit