Add UART4 and split init support to LinBus #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing a LIN bus connected to UART4 on high-density parts like STM32F103VCT6 needs support for DMA channel 2 in the HwInfo struct. Initialise the GPIO for RX which is necessary to get UART4 LIN connections to work and seems good practice for all pins. Remove duplicate field referencing the USART base register. Allow split initialisation where the memory is setup but no IO happens until a new Init() method is called. This allows integration into applications where the memory location is shared between multiple hardware variants. The existing constructor remains so current users are unaffected. Tests: - Build into Stm32-vcu and test with simulated VWCoolant LIN heater. Verify status values are returned and command sent to the device. - Build into stm32-sine with M3DU V1 board and simulated Tesla M3 oil pump. Verify command and status responses are delivered as expected.
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing a LIN bus connected to UART4 on high-density parts like STM32F103VCT6 needs support for DMA channel 2 in the HwInfo struct.
Initialise the GPIO for RX which is necessary to get UART4 LIN connections to work and seems good practice for all pins.
Remove duplicate field referencing the USART base
register.
Allow split initialisation where the memory is setup but no IO happens until a new Init() method is called. This allows integration into applications where the memory location is shared between multiple hardware variants. The existing constructor remains so current users are unaffected.
Tests: