Pass custom testset for @run_package_tests. #111
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 2 2
Lines 130 130
=======================================
Hits 121 121
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hm, I guess the question is whether it makes sense to have that as an option for just the command line runner? Presumably you would also want the custom testset used when running in VS Code? This generally strikes me as a global setting, and what we really need is a way to configure global settings... |
For my use case this makes sense, as I want a custom runner for a specific (headless) CI environment. In VS Code I'm fine with the default runner. I could also make a PR on top of this configuring it for a specific testitem, not unlike how @testset takes the custom argument? That should work in both modes? |
|
Ok, I think if this is actually a setting that makes sense not as a permanent property of the test items, but for certain test run environments, then this is actually the right way to implement it! |
| - `verbose`: Whether to run the tests in verbose mode. | ||
| """ | ||
| function run_tests(path; filter=nothing, verbose=false) | ||
| function run_tests(path; filter=nothing, verbose=false, testset=testset) |
There was a problem hiding this comment.
This is not yet fully implemented, right? Value here is never used, and the default argument not defined?
There was a problem hiding this comment.
@davidanthoff It is, testset is used on line 197,199,220, and defined on line 268.
There was a problem hiding this comment.
@davidanthoff Friendly bump
Fixes #110