Skip to content

fix: Use BigInteger for *_time colums #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Use BigInteger for *_time colums #591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
323555d
fix: Use BigInteger for *_time colums
ohayak Sep 4, 2025
c8f0ec1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions jupyter_scheduler/orm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,15 @@
from uuid import uuid4

import sqlalchemy.types as types
from sqlalchemy import Boolean, Column, Integer, String, create_engine, inspect
from sqlalchemy import (
BigInteger,
Boolean,
Column,
Integer,
String,
create_engine,
inspect,
)
from sqlalchemy.orm import declarative_base, declarative_mixin, registry, sessionmaker
from sqlalchemy.sql import text

Expand Down Expand Up @@ -83,8 +91,12 @@ class CommonColumns:
max_retries = Column(Integer, default=0)
min_retry_interval_millis = Column(Integer, default=0)
output_filename_template = Column(String(256))
update_time = Column(Integer, default=get_utc_timestamp, onupdate=get_utc_timestamp)
create_time = Column(Integer, default=get_utc_timestamp)
update_time = Column(
BigInteger().with_variant(Integer, "sqlite"),
default=get_utc_timestamp,
onupdate=get_utc_timestamp,
)
create_time = Column(BigInteger().with_variant(Integer, "sqlite"), default=get_utc_timestamp)
# All new columns added to this table must be nullable to ensure compatibility during database migrations.
# Any default values specified for new columns will be ignored during the migration process.
package_input_folder = Column(Boolean)
Expand All @@ -98,8 +110,8 @@ class Job(CommonColumns, Base):
job_definition_id = Column(String(36))
status = Column(String(64), default=Status.STOPPED)
status_message = Column(String(1024))
start_time = Column(Integer)
end_time = Column(Integer)
start_time = Column(BigInteger().with_variant(Integer, "sqlite"))
end_time = Column(BigInteger().with_variant(Integer, "sqlite"))
url = Column(String(256), default=generate_jobs_url)
pid = Column(Integer)
idempotency_token = Column(String(256))
Expand All @@ -114,7 +126,6 @@ class JobDefinition(CommonColumns, Base):
schedule = Column(String(256))
timezone = Column(String(36))
url = Column(String(256), default=generate_job_definitions_url)
create_time = Column(Integer, default=get_utc_timestamp)
active = Column(Boolean, default=True)
# All new columns added to this table must be nullable to ensure compatibility during database migrations.
# Any default values specified for new columns will be ignored during the migration process.
Expand Down
Loading