Skip to content

Bugfix / Correct stopping async cell execution #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −6
Open

Bugfix / Correct stopping async cell execution #1069

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6033cd
fix: add flag to allow to stop to avoid stopping too early after rest…
truongle1501 Aug 19, 2025
e40d44e
fix: syntax
truongle1501 Aug 19, 2025
140c7f4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions jupyter_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ async def _async_execute_interactive(
stdin_socket = None

# wait for output and redisplay it
can_stop = False
while True:
if timeout is not None:
timeout = max(0, deadline - time.monotonic())
Expand All @@ -564,12 +565,14 @@ async def _async_execute_interactive(
continue
output_hook(msg)

# stop on idle
if (
msg["header"]["msg_type"] == "status"
and msg["content"]["execution_state"] == "idle"
):
break
if msg["header"]["msg_type"] == "status":
state = msg["content"]["execution_state"]
# allow to stop
if state == "busy":
can_stop = True
# stop on idle
if state == "idle" and can_stop:
break

# output is done, get the reply
if timeout is not None:
Expand Down