Jpk/report to #41
Open
Jpk/report to #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
report-to header value is json
|
Thanks for the contribution :) |
juunas11
reviewed
Apr 16, 2019
|
It looks like both schema's mostly agree? I tried to use the W3C draft for building the validation code. We'll have to see if anything changes after the draft gets finalized. |
|
Also, in the standard, it looks like they're not wrapping multiple reports with square brackets. |
Separate groups by comma, no square brackets.
juunas11
requested changes
Apr 23, 2019
src/Joonasw.AspNetCore.SecurityHeaders/ReportTo/ReportToOptionsExtensions.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #40