BE: Chore: Overwrite Netty temporarily #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
yeikel
force-pushed
the
cve-CVE-2025-58057-CVE-2025-58056
branch
from
0eb11fb to
bc4a530
Compare
|
Thanks in advance! |
Haarolean
reviewed
Sep 10, 2025
| - "org.springframework.boot:*" | ||
| - "io.spring.dependency-management" | ||
| # All netty references are temporary overwrites that must be set carefully | ||
| # We do not need dependabot to send pull requests |
There was a problem hiding this comment.
why not? once some lib bumps it to say our 4.1.125, should be good to merge, nah?
There was a problem hiding this comment.
Because at least for now, we are only overwriting it for Spring transitively. Upgrading to a non-compatible version will just cause problems.
Even if 4.1.125.Final and 4.2.6.Final should be non breaking versions, experience says that Netty is very particular about conflicts and it just causes headaches.
As a side note, this dependabot configuration was not fully correct and it still created the PR #1326 but I'd suggest closing it instead of merging it.
I'll send a follow up to fix this
There was a problem hiding this comment.
@Haarolean Please see #1329
Haarolean
approved these changes
Sep 10, 2025
Haarolean
added
scope/backend
yeikel
added a commit
to yeikel/kafka-ui
that referenced
this pull request
Sep 10, 2025
Follow up for kafbat#1323
yeikel
added a commit
to yeikel/kafka-ui
that referenced
this pull request
Sep 11, 2025
Follow up for kafbat#1323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Overwrite Netty temporarily to fix CVE-2025-58056 and CVE-2025-58057
Is there anything you'd like reviewers to focus on?
See https://github.com/kafbat/kafka-ui/actions/runs/17544312907/job/49822128996
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)