Add new overlay and popup configuration options, allow to pass function which returns Element in element step config #508
+215
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'd like to propose these new features:
overlayEnableconfig option, enabled by default. This property allows library consumers to disable highlight overlay if they wish. (741f521)To keep the functionality of closing highlight when user clicks away I needed to add new window click listener when
overlayEnableis set tofalse(ffbe505)popoverStickToViewportconfig option, enabled by default. This property allows library consumers to disable popover viewport sticking. When it's set tofalsepopover always stays next to thestep.element(7fd1726)document.querySelector(5d1ec41)allowScrollconfig option, enabled by default. This property allows library consumers to disable body scrolling when driver is active (2d48c13)animateBetweenSameElementsconfig option, enabled by default. This property allows library consumers to disable popup animation when multiple steps are assigned to the same html element (be29918)requireRefreshcalls which resulted in broken layout (video of the issue - https://drive.google.com/file/d/1JjQZuctRSwiBExAQDDFbALvIrsjdqHKK/view?usp=sharing) (b11d4e2)step.element- this fixes the issue where user could make it soelementis not visible at all on the page - https://drive.google.com/file/d/1FDr8yNEsNc6onkIVNBBykxwFU5uCDEdD/view?usp=sharing (c86bf59)I've added interactive examples of config options in
index.html