Skip to content

Conversation

@justxuewei
Copy link
Member

@justxuewei justxuewei commented Jul 8, 2025

Rust 1.69.0, released in 2023, lags significantly behind the version used
by Kata Containers. Therefore, we bump it to 1.85.1.

The changes include fixes reported by cargo clippy. The results show
that everything is good now.

$ cargo clippy --all-targets --all-features -- -D warnings
    Checking cgroups-rs v0.3.5 (/mnt/hiksemi/developer/cgroups-rs)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.38s

Rust 1.69.0, released in 2023, lags significantly behind the version used
by Kata Containers. Therefore, we bump it to 1.85.1.

Signed-off-by: Xuewei Niu <[email protected]>
Most of the issues are small, but `fold()`. The usage of `fold()` in these
cases confuses me a lot, so that I don't follow the sugguestions from
clippy to replace `fold()` with `try_fold()`. Instead, I replace them with
`map() + collect()`.

Signed-off-by: Xuewei Niu <[email protected]>
The cargo complaints that ".cargo/config" is deprecated in favor of
".cargo/config.toml". Therefore, the file is renamed to it to make cargo
happy.

Signed-off-by: Xuewei Niu <[email protected]>
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Apokleos!

@fidencio fidencio merged commit 6e273cd into main Jul 9, 2025
10 of 11 checks passed
@justxuewei justxuewei deleted the bump-rust branch July 9, 2025 08:42
Tim-Zhang added a commit to Tim-Zhang/cgroups-rs that referenced this pull request Jul 22, 2025
@Tim-Zhang Tim-Zhang mentioned this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants