Skip to content

Update to newest versions, set actual schema version for ce_dataschema header #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update to newest versions, set actual schema version for ce_dataschema header #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bbdb53f
Update to new avro plugin
Sep 28, 2022
23aee95
Bump version of kafka-avro-serializer to 7.2.1
Sep 28, 2022
4690cb3
Bump version of avro to 1.11.1
Sep 28, 2022
8468978
Bump version of cloudevents-kafka to 2.4.0
Sep 28, 2022
66f8759
Bump version of junit-jupiter to 5.9.0
Sep 28, 2022
a7facfc
Bump version of lombok to 1.18.24
Sep 28, 2022
535655b
Bump version of kafka to 3.2.3
Sep 28, 2022
ce96f84
Use actual schema version for ce_dataschema instead of last version
Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id 'com.commercehub.gradle.plugin.avro' version '0.99.99'
id 'com.github.davidmc24.gradle.plugin.avro' version '1.5.0'
id 'java'
id 'java-library'
id 'maven'
Expand All @@ -15,16 +15,16 @@ repositories {
}

dependencies {
implementation 'io.confluent:kafka-avro-serializer:5.5.3'
implementation 'org.apache.avro:avro:1.10.2'
implementation 'io.cloudevents:cloudevents-kafka:2.0.0'
implementation 'io.confluent:kafka-avro-serializer:7.2.1'
implementation 'org.apache.avro:avro:1.11.1'
implementation 'io.cloudevents:cloudevents-kafka:2.4.0'

testImplementation 'org.junit.jupiter:junit-jupiter-api:5.7.1'
testImplementation 'org.junit.jupiter:junit-jupiter-engine:5.7.1'
testImplementation 'org.apache.kafka:kafka_2.12:2.7.0'
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.9.0'
testImplementation 'org.junit.jupiter:junit-jupiter-engine:5.9.0'
testImplementation 'org.apache.kafka:kafka_2.12:3.2.3'

compileOnly 'org.projectlombok:lombok:1.18.18'
annotationProcessor 'org.projectlombok:lombok:1.18.16'
compileOnly 'org.projectlombok:lombok:1.18.24'
annotationProcessor 'org.projectlombok:lombok:1.18.24'
}

group = 'io.github.kattlo'
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/io/github/kattlo/cloudevents/KafkaAvroCloudEventSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.util.Map;
import java.util.Objects;

import io.confluent.kafka.schemaregistry.avro.AvroSchema;
import org.apache.kafka.common.errors.SerializationException;
import org.apache.kafka.common.header.Headers;

Expand Down Expand Up @@ -70,7 +71,7 @@ public void configure(Map<String, ?> configs, boolean isKey) {
configs.get(KafkaAvroSerializerConfig.SCHEMA_REGISTRY_URL_CONFIG);

log.debug("{}={}", KafkaAvroSerializerConfig.SCHEMA_REGISTRY_URL_CONFIG,
schemaRegistryUrl);;
schemaRegistryUrl);

} else {
throw new IllegalArgumentException(CloudEventSerializer.ENCODING_CONFIG + "=" + encoding + " not supported");
Expand Down Expand Up @@ -109,8 +110,7 @@ public byte[] serialize(String topic, Headers headers, Object event) {

// get the versionId of registered schema
try {
var versions = super.schemaRegistry.getAllVersions(subjectName);
var version = versions.get(versions.size() -1);
var version = super.schemaRegistry.getVersion(subjectName, new AvroSchema(value.getSchema()));
log.debug("Schema versionId {}", version);

var dataschema = schemaRegistryUrl + "/subjects/" + subjectName + "/versions/" + version + "/schema";
Expand Down Expand Up @@ -147,7 +147,7 @@ public String canonicalString() {
}

@Override
public boolean isBackwardCompatible(ParsedSchema arg0) {
public List<String> isBackwardCompatible(ParsedSchema arg0) {
throw new UnsupportedOperationException();
}

Expand Down