Skip to content

Conversation

harshaljanjani
Copy link
Collaborator

Reference

Add T5Gemma presets after the model merge (#2339)

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

@github-actions github-actions bot added the Gemma Gemma model specific issues label Aug 28, 2025
@harshaljanjani harshaljanjani self-assigned this Aug 28, 2025
@sachinprasadhs
Copy link
Collaborator

Since the small presets are uploaded, change the presets names to kaggle presets from Keras here

"kaggle_handle": "kaggle://harshaljanjani/t5gemma/keras/t5gemma_b_b_prefixlm_it",

And here
preset_name = "hf://harshaljanjani/tiny-t5gemma-test"

@harshaljanjani
Copy link
Collaborator Author

harshaljanjani commented Aug 29, 2025

Good day @sachinprasadhs!

"kaggle_handle": "kaggle://harshaljanjani/t5gemma/keras/t5gemma_b_b_prefixlm_it",

The first preset you mentioned here has been changed with this PR along with the others; possibly you are viewing the original version of the file before the diff?

preset_name = "hf://harshaljanjani/tiny-t5gemma-test"

This is not a Kaggle preset but an HF preset, which tests direct HF checkpoint loading. We cannot switch this out with the original preset from Google because the model is gated, and the GPU CI fails due to inadequate permissions. To this end, I uploaded the smallest HF preset to my account and included it instead.

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Aug 29, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 29, 2025
Copy link
Collaborator

@sachinprasadhs sachinprasadhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments.

@harshaljanjani harshaljanjani marked this pull request as ready for review August 30, 2025 05:27
@harshaljanjani
Copy link
Collaborator Author

@sachinprasadhs Resolved, thanks!

@harshaljanjani
Copy link
Collaborator Author

harshaljanjani commented Aug 30, 2025

@divyashreepathihalli @sachinprasadhs Errors unrelated to T5Gemma.
Also, I've updated and completed the model page, feel free to have a look!
https://www.kaggle.com/models/keras/t5-gemma/

@harshaljanjani harshaljanjani added the kokoro:force-run Runs Tests on GPU label Aug 30, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gemma Gemma model specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants