Miscellaneous fixes for DHCP server, bridge ports, and CI #1211
+91
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses disk space issues in GitHub Actions for generic x86_64 builds by removing unused tools (Android SDK, .NET, Docker images, etc.) before the build starts. This frees up ~30GB of space. Fixes #1210 Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
A valid DHCP server setup for a subnet is one of pool and/or at least one static host entry/lease. If pool is enabled the pool must have a start and an end address. To allow setting up a DHCP server with no pool and at least one static host entry/lease, we make the pool a presence container, otherwise the pool will always be set and trigger the below inference. When an interactive CLI/Web user enables the address pool we infer a default range .100-.250, but only for /24, C-class networks. This is what most users know and expect. The YANG model now validates that: - If an address pool is created, both start-address and end-address must be set - Each subnet must have either a pool or at least one static host entry - The pool container is now a presence container, so "no pool" fully deletes it Fixes #1121 Signed-off-by: Joachim Wiberg <[email protected]>
Bridge ports should not have IP addresses configured. The IP address should be configured on the bridge interface itself, not its member ports. Add YANG must expression to enforce this rule at configuration time. Fixes #1122 Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
Example:
Checklist
Tick relevant boxes, this PR is-a or has-a: