Fix integer overflow vulnerability in AbstractIoBuffer.write() #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The current implementation lacks proper bounds checking in the write(byte[], int, int) method.
Specifically, it does not guard against integer overflow when calculating offset + length, which may result in out-of-bounds memory access and potential data corruption.
Fix:
Added validation to ensure offset and length are within safe bounds, following secure coding practices found in other hardened buffer implementations.
This prevents integer overflow and enforces correct array indexing.
Security Reference: